Skip to content

Commit 2979663

Browse files
rubennortemeta-codesync[bot]
authored andcommitted
Remove legacy Paper renderer shim cleanup from artifact commit workflow (facebook#36297) (facebook#56483)
Summary: Pull Request resolved: facebook#56483 ## Summary PR facebook#36285 deleted the Paper (legacy) renderer, including the shim file `scripts/rollup/shims/react-native/ReactNative.js`. However, the `runtime_commit_artifacts` workflow still tries to `rm` this file after moving build artifacts into `compiled-rn/`. Since the file no longer exists in the build output, `rm` (without `-f`) fails and kills the entire step. This has caused **every run of the Commit Artifacts workflow to fail since facebook#36285 landed on April 16**, blocking both `builds/facebook-www` and `builds/facebook-fbsource` branches from receiving new build artifacts. This in turn blocks DiffTrain from syncing React changes into Meta's internal monorepo. DiffTrain build for [bf45a68dd35ed08860b6a70fed641dfe6d7d290d](facebook/react@bf45a68) Reviewed By: zeyap Differential Revision: D101329586 fbshipit-source-id: d38877d5cc964c46257cb73678f80d0a7c729d90
1 parent f0c62da commit 2979663

1 file changed

Lines changed: 1 addition & 31 deletions

File tree

packages/react-native/Libraries/Renderer/shims/ReactNativeTypes.js

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noformat
88
* @nolint
99
* @flow strict
10-
* @generated SignedSource<<c0e57723772ea5f1aa8c3c897ac3c216>>
10+
* @generated SignedSource<<4ab83fd2606d6a4d374ef914f231d9c1>>
1111
*/
1212

1313
import type {
@@ -138,36 +138,6 @@ export type RenderRootOptions = {
138138
onDefaultTransitionIndicator?: () => void | (() => void),
139139
};
140140

141-
/**
142-
* Flat ReactNative renderer bundles are too big for Flow to parse efficiently.
143-
* Provide minimal Flow typing for the high-level RN API and call it a day.
144-
*/
145-
export type ReactNativeType = {
146-
findHostInstance_DEPRECATED<TElementType: React.ElementType>(
147-
componentOrHandle: ?(React.ElementRef<TElementType> | number),
148-
): ?PublicInstance,
149-
findNodeHandle<TElementType: React.ElementType>(
150-
componentOrHandle: ?(React.ElementRef<TElementType> | number),
151-
): ?number,
152-
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
153-
dispatchCommand(
154-
handle: PublicInstance,
155-
command: string,
156-
args: Array<mixed>,
157-
): void,
158-
sendAccessibilityEvent(handle: PublicInstance, eventType: string): void,
159-
render(
160-
element: React.MixedElement,
161-
containerTag: number,
162-
callback: ?() => void,
163-
options: ?RenderRootOptions,
164-
): ?React.ElementRef<React.ElementType>,
165-
unmountComponentAtNode(containerTag: number): void,
166-
unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
167-
+unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
168-
...
169-
};
170-
171141
export opaque type Node = mixed;
172142
export opaque type InternalInstanceHandle = mixed;
173143

0 commit comments

Comments
 (0)