Upgrade and clean dependencies#82
Merged
jasonwhite merged 9 commits intojasonwhite:masterfrom Nov 16, 2025
Merged
Conversation
Owner
|
Would you mind rebasing now that #81 is merged? Looks like there are now some merge conflicts. Otherwise, all changes look good to me. |
# Conflicts: # Cargo.lock # src/app.rs # src/sha256.rs # src/storage/faulty.rs # tests/test_local.rs # tests/test_s3.rs
Contributor
Author
|
OK, done. For the Push Docker Image failure, I think you need to change the docker image you created. rudolfs/.github/workflows/ci.yml Line 116 in b4c7c6d I guess the docker image used here is using an old Rust toolchain, but I cannot change the image that you created. |
Owner
|
Fixed the Docker build in #83. |
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides #81 , I've been trying to upgrade and clean some dependencies. Most of the changes are non-breaking, but there's one major change: we use
hybrid-arrayinstead ofgeneric-arraydue to the latestsha2upgrade.Referring to RustCrypto/traits#1319 (comment), which migrated
digestthatsha2depends on fromgeneric-arraytohybrid-array, I think this major change is well justified.I don't think the changes from this PR will break any functionalities, but can you run tests and see if anything breaks? Thanks!
Note that this is based on #81, which is not merged yet, so you still see various style changes due to the changes included in #81.