Set BLACKLIST_AFTER_ROTATION by default to False at docs (#455)

mohmyo · Andrew-Chen-Wang · web-flow · commit d9667ddbd1f5 · 2021-09-19T14:21:47.000-04:00
* Set BLACKLIST_AFTER_ROTATION to False in docs

* Set BLACKLIST_AFTER_ROTATION default to False

* Update test settings

Co-authored-by: Andrew Chen Wang &lt;60190294+Andrew-Chen-Wang@users.noreply.github.com&gt;
diff --git a/docs/settings.rst b/docs/settings.rst
@@ -18,7 +18,7 @@ Some of Simple JWT's behavior can be customized through settings variables in
       'ACCESS_TOKEN_LIFETIME': timedelta(minutes=5),
       'REFRESH_TOKEN_LIFETIME': timedelta(days=1),
       'ROTATE_REFRESH_TOKENS': False,
-      'BLACKLIST_AFTER_ROTATION': True,
+      'BLACKLIST_AFTER_ROTATION': False,
       'UPDATE_LAST_LOGIN': False,
 
       'ALGORITHM': 'HS256',
diff --git a/rest_framework_simplejwt/settings.py b/rest_framework_simplejwt/settings.py
@@ -13,7 +13,7 @@
     'ACCESS_TOKEN_LIFETIME': timedelta(minutes=5),
     'REFRESH_TOKEN_LIFETIME': timedelta(days=1),
     'ROTATE_REFRESH_TOKENS': False,
-    'BLACKLIST_AFTER_ROTATION': True,
+    'BLACKLIST_AFTER_ROTATION': False,
     'UPDATE_LAST_LOGIN': False,
 
     'ALGORITHM': 'HS256',
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -50,6 +50,9 @@ def pytest_configure():
         PASSWORD_HASHERS=(
             'django.contrib.auth.hashers.MD5PasswordHasher',
         ),
+        SIMPLE_JWT={
+            'BLACKLIST_AFTER_ROTATION': True,
+        },
     )
 
     try:

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@ def pytest_configure():`
`50`	`50`	`PASSWORD_HASHERS=(`
`51`	`51`	`'django.contrib.auth.hashers.MD5PasswordHasher',`
`52`	`52`	`),`
	`53`	`+ SIMPLE_JWT={`
	`54`	`+ 'BLACKLIST_AFTER_ROTATION': True,`
	`55`	`+ },`
`53`	`56`	`)`
`54`	`57`
`55`	`58`	`try:`