Set BLACKLIST_AFTER_ROTATION by default to False at docs

[mohmyo]

No description provided.

[Andrew-Chen-Wang]

Please also set the default value in the Python code itself in settings.py. I've done it. If there are any tests that fail, please resolve them with override_settings. Thanks.

[mohmyo]

There is only one test case that makes tests fails on circleci, because of this line when we set BLACKLIST_AFTER_ROTATION to False by default BlacklistedTokenis not imported by default too.
This wasn't the case for the previous version, it was imported by default so it didn't cause any troubles.

[mohmyo]

So should we just import BlacklistedToken anyway and remove that conditional import line or there is a better approach here?

[Andrew-Chen-Wang]

@mohmyo just monkeypatch it. Use pytest's init hook and monkey patch api_settings to return True for the module.

Regarding "should we just import BlacklistedToken anyway", I don't know if this is true, but if you don't have the app installed, then it will raise some form of ModuleNotFound error. But please test it! I'd actually much rather have it be imported, but I suspect the conditional import is there for a reason.

[mohmyo]

I tried to remove the condition and import it anyway, tests passed like normal as before. so let's go this way?

[Andrew-Chen-Wang]

Please try creating a Django project. I suspect it works because of an INSTALLED_APP

[mohmyo]

mmmm, without trying I think you are right, I missed that part for INSTALLED_APPS. I will go with monkeypatch as you suggested.

[mohmyo]

To be more clear as I think there is a bit of confusion here, this is the error:
FAILED tests/test_token_blacklist.py::TokenVerifySerializerShouldHonourBlacklist::test_token_verify_serializer_should_honour_blacklist_if_blacklisting_enabled - NameError: name 'BlacklistedToken' is not defined

The problem is serializers.py doesn't import BlacklistedToken as it was loaded by default without it, so how should I force reloading the serializers.py when BLACKLIST_AFTER_ROTATION is set to True hence it will import our model?

I'm not familiar with pytest, I tried but I'm not going anywhere.

[Andrew-Chen-Wang]

@mohmyo it's fine; I got it.

[Andrew-Chen-Wang]

thanks for creating the PR!

[mohmyo]

Thank you for maintaining this great package!