Skip to content

Incorrect typing for refresh token. #821

@proofit404

Description

@proofit404

Let say we have code block like this:

def create_token(profile_id: ProfileId) -> Token:
    user = User.objects.get(profiletable=profile_id)
    refresh = RefreshToken.for_user(user)
    return str(refresh.access_token)

That would produce error in mypy:

venv/lib/python3.12/site-packages/web/repositories/token.py: note: In function "create_token":
venv/lib/python3.12/site-packages/web/repositories/token.py:13:16: error: "Token" has no attribute "access_token" 
[attr-defined]
        return str(refresh.access_token)
                   ^~~~~~~~~~~~~~~~~~~~

Token.for_user class method returns cls() which allows subclasses returns it's own instances. But annotations says it would always be a Token.

Maybe typing.Self would work?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions