You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for this great library! I would like to contribute to this project with a view to effectively log out users. Currently the only way of doing it is by manually blacklisting the corresponding token. However, if a user whishes to log out, the server should invalidate the refresh token triggered by a logout request. This PR aims to fill in that gap. Many thanks for your feedback!
Hey @hodossy ! Thanks for contributing! Please add some tests so that we know a token is actually invalid. Being a security library, we want to look for anything that can result in bad stuff. Scratch that! GitHub notif just showed me one commit! My bad.
I haven't had the time to take a look back at this repo in awhile (still awaiting response from David to push new version out). One of the big issues lately seems to be the blacklist app, so you'll have to wait once you finish creating those tests. Ref above comment I think, before David pushes out a new version, this can also be included since #71 is going to take awhile to finish reviewing.
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Hope you don't mind, but I'm going to let @davesque review this one, as well, before merging just in case I'm missed something in my review. Thanks for the PR @hodossy!
@hodossy Could you tell me how to use log out feature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this great library! I would like to contribute to this project with a view to effectively log out users. Currently the only way of doing it is by manually blacklisting the corresponding token. However, if a user whishes to log out, the server should invalidate the refresh token triggered by a logout request. This PR aims to fill in that gap. Many thanks for your feedback!