Skip to content

Add DRF 3.14 Support#623

Merged
Andrew-Chen-Wang merged 4 commits intomasterfrom
drf-3.14-support
Apr 9, 2023
Merged

Add DRF 3.14 Support#623
Andrew-Chen-Wang merged 4 commits intomasterfrom
drf-3.14-support

Conversation

@Andrew-Chen-Wang
Copy link
Copy Markdown
Member

fixes #622

Copy link
Copy Markdown
Member

@2ykwang 2ykwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jerr0328
Copy link
Copy Markdown
Contributor

I think tox.ini also needs to be updated to define the new DRF version + constraints

@2ykwang
Copy link
Copy Markdown
Member

2ykwang commented Feb 5, 2023

@Andrew-Chen-Wang How about removing the Django main from the test matrix?

@Andrew-Chen-Wang
Copy link
Copy Markdown
Member Author

Andrew-Chen-Wang commented Feb 5, 2023

yea that sounds good with me. feel free to edit the branch

@2ykwang
Copy link
Copy Markdown
Member

2ykwang commented Feb 5, 2023

Can you check the patch? @jerr0328 @Andrew-Chen-Wang

@abczzz13 abczzz13 mentioned this pull request Mar 8, 2023
@johnthagen
Copy link
Copy Markdown
Contributor

johnthagen commented Apr 8, 2023

@Andrew-Chen-Wang Anything blocking this PR from being merged (other than a few conflicts)?

@Andrew-Chen-Wang
Copy link
Copy Markdown
Member Author

thanks for reminder

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit f298efa into master Apr 9, 2023
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the drf-3.14-support branch April 9, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test with DRF 3.14

4 participants