Skip to content

Remove EOL Python, Django and DRF versions#754

Merged
Andrew-Chen-Wang merged 2 commits intojazzband:masterfrom
KOliver94:remove-eol
Oct 30, 2023
Merged

Remove EOL Python, Django and DRF versions#754
Andrew-Chen-Wang merged 2 commits intojazzband:masterfrom
KOliver94:remove-eol

Conversation

@KOliver94
Copy link
Copy Markdown
Contributor

@KOliver94 KOliver94 commented Sep 18, 2023

Remove all no longer supported Python, Django and DRF versions. Also fixes #684 as after Python 3.8 no workaround is necessary.

Closes #702

@KOliver94
Copy link
Copy Markdown
Contributor Author

KOliver94 commented Oct 8, 2023

Hey @Andrew-Chen-Wang,

Can you take a look at this PR?

Thanks!

@kozlek
Copy link
Copy Markdown
Contributor

kozlek commented Oct 13, 2023 •
edited
Loading

Python 3.12 has been released and pkg_resources is not installed by default in venv.
This means djangorestframework-simplejwt doesn't work on 3.12 if users forget to install pkg_resources aside.

This is not blocking, but this PR will ease python 3.12 upgrade 🙂

Andrew-Chen-Wang
Andrew-Chen-Wang requested changes Oct 17, 2023
View reviewed changes
Comment thread .github/workflows/test.yml
drf-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
python-version: [ '3.8', '3.9', '3.10', '3.11']
django-version: ['3.2', '4.1', '4.2']
drf-version: ['3.12', '3.13', '3.14']
Copy link
Copy Markdown
Member

@Andrew-Chen-Wang Andrew-Chen-Wang Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does drf 3.14 support django 4.2?

Copy link
Copy Markdown
Contributor Author

@KOliver94 KOliver94 Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it does not officially. However, based on the conversations on DRF (encode/django-rest-framework#8942) it seems nothing breaks with Django 4.2 most of the times. Moreover, DRF 3.14 is already being tested with Django 4.2 here on master.

@johnthagen
Copy link
Copy Markdown
Contributor

johnthagen commented Oct 30, 2023 •
edited
Loading

DeprecationWarning's are now being thrown from pkg_resources, which will fail tests that set warnings as errors. It would be great to get this merged and released onto PyPI.

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit 19cf38e into jazzband:master Oct 30, 2023
@yardensachs
Copy link
Copy Markdown

yardensachs commented Oct 30, 2023

love it thank you!

@KOliver94 KOliver94 deleted the remove-eol branch October 30, 2023 20:27
@foarsitter foarsitter mentioned this pull request Nov 1, 2023
Merged
@robd003 robd003 mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andrew-Chen-Wang Andrew-Chen-Wang Andrew-Chen-Wang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reference to pkg_resources

5 participants

@KOliver94 @kozlek @johnthagen @yardensachs @Andrew-Chen-Wang
⚡