Remove usages of deprecated datetime.utcnow() and datetime.utcfromtimestamp()#765
Merged
Andrew-Chen-Wang merged 2 commits intojazzband:masterfrom Dec 4, 2023
Merged
Remove usages of deprecated datetime.utcnow() and datetime.utcfromtimestamp()#765Andrew-Chen-Wang merged 2 commits intojazzband:masterfrom
Andrew-Chen-Wang merged 2 commits intojazzband:masterfrom
Conversation
50-Course
approved these changes
Nov 25, 2023
Member
50-Course
left a comment
There was a problem hiding this comment.
...
aware_utcnowanddatetime_from_epochcan still return naive datetime if settings.USE_TZ is False (original behaviour) -> we might want to force aware datetime in a future release
Thank you for this PR! Would be approving changes since, there is no breakage in library code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
datetime.utcnow()anddatetime.utcfromtimestamp()freezegunas test dependency to handle properly time patching during testsNotes:
aware_utcnowanddatetime_from_epochcan still return naive datetime if settings.USE_TZ is False (original behaviour) -> we might want to force aware datetime in a future releasemake_utcfunction has been kept but it is only used by our tests, not library code