Add specific "token expired" exceptions#830
Merged
vgrozdanic merged 2 commits intojazzband:masterfrom Jan 11, 2025
Merged
Conversation
To later allow specific handling for this case in the layers above.
To allow the caller to handle expired tokens separately from invalid ones without resorting to string matching.
Andrew-Chen-Wang
approved these changes
Jan 2, 2025
Member
Andrew-Chen-Wang
left a comment
Andrew-Chen-Wang
left a comment
There was a problem hiding this comment.
This looks great thank you
vgrozdanic
approved these changes
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it possible for the layers above to handle expired tokens differently from invalid tokens (use different error codes or whatever), without resorting to doing string-matching on the error message.