Draft
Conversation
Also updated related dependencies Notes: 1. Hard-coded resolutionStrategy versions in build.gradle 2. Hard-coded rc.6 release of JBake 2.7.0
msgilligan
commented
Nov 30, 2022
Author
msgilligan
left a comment
msgilligan
left a comment
There was a problem hiding this comment.
This review gives some reasons why this is a draft PR>
| resolutionStrategy { | ||
| force "com.github.jnr:jnr-posix:3.1.15" | ||
| force "com.github.jnr:jnr-constants:0.10.3" | ||
| force "com.github.jnr:jffi:1.3.9" |
Author
There was a problem hiding this comment.
Hard-coded version numbers here are one reason why this is a DRAFT PR.
| commonsIoVersion = 2.8.0 | ||
| jbakeVersion = 2.6.7 | ||
| commonsIoVersion = 2.11.0 | ||
| jbakeVersion = 2.7.0-rc.6 |
Author
There was a problem hiding this comment.
-rc.6 here is another reason this is a DRAFT PR
|
|
||
| @Shared | ||
| String latestJbakeVersion = '2.6.7' | ||
| String latestJbakeVersion = '2.7.0-rc.6' |
Author
There was a problem hiding this comment.
-rc.6 here is another reason this is a DRAFT PR
This was referenced Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on macOS with Apple Silicon.
Also updated related dependencies
Notes: