#1036: fix path for listing public repositories#1852
Merged
yegor256 merged 2 commits intojcabi:masterfrom May 6, 2026
Merged
Conversation
916f506 to
bafbc75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yegor256 this PR fixes #1036.
Bug
Repos#iterate(String)(implemented byRtRepos) is documented to call the GitHub "List all public repositories" endpoint (/repositories?since=...), but it was issuing the request against the API root:/?since=.... As a result, GitHub returned the JSON object describing the API root rather than the expected JSON array, andRtPaginationfailed withjavax.json.JsonException: Cannot read JSON array, found JSON object.Fix
Add the missing
/repositoriespath segment inRtRepos#iterate:Commits
#1036: regression test asserting /repositories pathaddsRtReposTest#iterateReposUsesPublicRepositoriesPath, which intercepts the outgoing request and asserts the URI ends with/repositories?since=<id>. Verified to fail on master and pass with the fix applied.#1036: prepend /repositories path in RtRepos#iterateis the one-line fix.Build status
mvn -DskipITs testpasses locally (717 tests, 0 failures).mvn -Pqulice installreports the same 837 PMD violations that already exist onmaster(e.g. PR #1168: handle JSON null in User.Smart#name() and #hasName() #1851 was merged with the identicalmvn (ubuntu-24.04, 24)failure). I confirmed locally that this branch produces exactly the same 837 violations asmaster— i.e. this PR does not introduce any new qulice violations.