Param sliders for kontakt and kk#1227
Conversation
|
I'm away for a few days, so I can't look at where exactly you've put this sleep. If I had to guess, I'd say this relates to the fact that many plugins can't report formatted values for anything other than the current value. That means OSARA can't figure out where the next discrete value is. That would be even worse if the plugin also refused to report the formatted value for a newlyset value for a short period of time. OSARA would have no way of knowing this. I'm not ruling out some weird timing bug in OSARA though. |
|
Should I wait for you to get back before testing on a wider spread of machines? |
|
Not necessarily - data is always useful - but a 5 ms sleep is definitely not an acceptable solution to land, as it will slaughter performance when moving fast. |
I obviously considered that, but didn't find any other solution. We tried to go even lower and noticed that setting e.g. 1ms will not fix the issue. Unless we can actually get hold of the issue and fix it at its core 5 ms feels reasonably good ATM really, we tried with various constellations already and in none of them the delay is actually noticeable, as it also just occurs when arrowing or paging up or down within the parameter dialog. Obviously fixing the actual issue is to be preferred for sure. |
|
My concern is that holding down the arrow keys for a long time will get very laggy. Is that somewhing you've tested for? If it is a problem, it could be fixed with CallLater instead of sleep. This way, you can cancel it if the next key press arrives before the previous one is processed. It also avoids blocking the UI. |
|
Holding down keys was still ok on a good machine. I'll update the PR to use callLater before checking on slower ones, thanks for the tip. |
|
Is this only reproducible when a sound is loaded? I tested several channel volume parameters with KK but didn't have a patch loaded at the time, and I can't reproduce the issue. |
|
Yeah, I was playing with KK parameters yesterday and didn't experience this either. It wasn't snapping to values when I pressed arrow keys - i.e. I had to keep pressing with no reporting until it got to a new formatted value - but that's expected with plugins that can't format values other than the current set value. |
4 participants
After discussion in #593, I've been investigating why values aren't being reported consistently when adjusting sliders in OSARA's FX Parameters dialog. Test plug-ins here have been Komplete Kontrol 3, Kontakt 6, 7 and 8.
STR:
A 5ms sleep in paramsUI.cpp before we update value seems to stabilize reporting. As yet I don't know why that helps and I'm not proposing this as an actual solution, just a temporary hack to see whether behaviour also improves on a wider pool of machines. I'm especially interested in hearing about whether it helps on older/slower Windows and Macs. Not sure how long we need to wait for yet, or what a nicer implementation would be.
Tagging @Timtam and @jennykbrennan, they've been helping chase it.