Wire tool selection and MCP error handling into chats endpoint#175
Merged
dhq-boiler merged 3 commits intoMar 9, 2026
Merged
Conversation
Accept tool_ids parameter to select MCP tools for chat requests, convert them via McpToolAdapter, and pass to LlmRbFacade. Add error handlers for McpConnectionError and McpProtocolError, and format responses to include tool call details when present.
ledsun
reviewed
Mar 9, 2026
Ensures unexpected types are safely converted to a string rather than being passed through as-is.
Move the query for finding active MCP tools by IDs from ChatsController into the User model for better separation of concerns.
ledsun
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要