This repository was archived by the owner on Nov 18, 2017. It is now read-only.
[Feature] Support Graphite input plugin configuration#16
Closed
noroute wants to merge 1 commit intojdowning:masterfrom
Closed
[Feature] Support Graphite input plugin configuration#16noroute wants to merge 1 commit intojdowning:masterfrom
noroute wants to merge 1 commit intojdowning:masterfrom
Conversation
Enables support for: * database name * input port * disable plugin closes jdowning#14, although it only supports one plugin at the moment. Factor out common parts when supporting additional plugins.
Owner
|
Thanks for the PR. I decided to go a different route and drop the inifile usage in favor of a parameterized template. I believe I have solved the Graphite input-plugin configuration with #18. Let me know what you think. |
Author
|
It looks good so far. Will hook up our code that's already setting up influxdb instances for us and let you know next week. The all-in-on template approach has the problem that every plugin/feature that is added adds more parameters (where there are already lots of). That's why I tried to encapsulate that. |
Owner
|
This project is no longer maintained. I recommend you check out golja/influxdb for an updated Puppet module for InfluxDB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables support for:
closes #14, although it only supports one plugin at the moment.
Factor out common parts when supporting additional plugins.