fix(deps): update reqwest to 0.13#348
Conversation
reqwest 0.13 renamed TLS feature flags. The old `rustls-tls-native-roots-no-provider` is now split into `rustls-native-certs` + `rustls-no-provider`. Closes #333 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the reqwest dependency from version 0.12 to 0.13 and updates the Cargo.lock file accordingly, introducing several new dependencies including rustls-platform-verifier and jni. Feedback suggests that for reqwest 0.13, it is more idiomatic to use the rustls-tls-native-roots feature instead of rustls-native-certs to leverage the more robust system trust store integration provided by the rustls-platform-verifier crate.
| reqwest = { version = "0.12", default-features = false, features = [ | ||
| "rustls-tls-native-roots-no-provider", | ||
| reqwest = { version = "0.13", default-features = false, features = [ | ||
| "rustls-native-certs", |
There was a problem hiding this comment.
In reqwest 0.13, the rustls-tls-native-roots feature is the direct successor to the native roots functionality from 0.12. It now leverages the rustls-platform-verifier crate, which provides more robust integration with system trust stores (especially on Windows and macOS) compared to the older rustls-native-certs crate.
Since your Cargo.lock shows that rustls-platform-verifier is already being included (as it is now a default dependency of the rustls-tls backend in 0.13), switching to rustls-tls-native-roots is more idiomatic for this version and avoids explicitly opting into the legacy crate-based root loading.
| "rustls-native-certs", | |
| "rustls-tls-native-roots", |
Greptile SummaryUpgrades reqwest from 0.12 to 0.13, replacing the removed Confidence Score: 5/5Safe to merge — clean dependency upgrade with correct feature flag mapping and no regressions. The feature flag rename is accurate for reqwest 0.13, ring remains the sole crypto provider (aws-lc-rs is absent from the lock), the explicit provider installation in src/main.rs satisfies rustls-no-provider, and the hyper-rustls ring override is intact. All 400 tests pass. No logic changes outside dependency declarations. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[reqwest 0.13] -->|rustls-native-certs| B[Native OS cert store]
A -->|rustls-no-provider| C[App installs crypto provider]
C --> D["ring::default_provider().install_default()\nsrc/main.rs"]
A --> E[hyper-rustls 0.27]
E -->|features: ring,http1,http2,tls12| F[rustls 0.23 + ring]
F --> G[No aws-lc-rs in dep tree]
B --> H[TLS connections verified\nagainst OS trust store]
Reviews (1): Last reviewed commit: "fix(deps): update reqwest to 0.13" | Re-trigger Greptile |
## 🤖 New release * `pitchfork-cli`: 2.5.0 -> 2.6.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [2.6.0](v2.5.0...v2.6.0) - 2026-04-12 ### Added - *(proxy)* auto start when visiting the proxied URL ([#347](#347)) ### Fixed - some issues related to sudo supervisor ([#323](#323)) - *(port)* should fail when ready_port is in use ([#350](#350)) - *(deps)* update rcgen to 0.14 ([#349](#349)) - *(deps)* update reqwest to 0.13 ([#348](#348)) - detect port conflicts on loopback addresses, not just 0.0.0.0 ([#345](#345)) - narrow REAPED_STATUSES cfg to non-Linux unix only ([#346](#346)) - *(deps)* update rust crate ratatui to 0.30 ([#331](#331)) - *(deps)* update rust crate toml to v1 ([#344](#344)) - *(deps)* update rust crate strum to 0.28 ([#334](#334)) - *(deps)* update rust crate notify-debouncer-full to 0.7 ([#330](#330)) - *(deps)* update rust crate nix to 0.31 ([#329](#329)) - *(deps)* update rust crate listeners to 0.5 ([#328](#328)) - *(deps)* update rust crate sysinfo to 0.38 ([#335](#335)) - *(deps)* update rust crate cron to 0.16 ([#324](#324)) - *(deps)* update rust crate crossterm to 0.29 ([#325](#325)) ### Other - *(deps)* update rust crate rmcp to v1.4.0 ([#327](#327)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this PR only bumps the crate version and updates release notes, with no runtime code changes. > > **Overview** > Prepares the `pitchfork-cli` **v2.6.0** release by bumping the package version from `2.5.0` to `2.6.0` in `Cargo.toml`/`Cargo.lock`. > > Updates `CHANGELOG.md` with the `2.6.0` release notes (proxy auto-start behavior, several fixes, and dependency updates). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit faea6c5. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Summary
rustls-tls-native-roots-no-provider→rustls-native-certs+rustls-no-providerCloses #333
Test plan
cargo buildsucceedscargo nextest run— 400 passed, 0 failedhyper-rustlsring override still applies🤖 Generated with Claude Code
Note
Medium Risk
Dependency upgrade changes TLS/certificate verification feature flags and pulls in new platform-specific cert verifier crates, which could affect HTTPS behavior across OSes.
Overview
Updates
reqwestfrom0.12to0.13and adjusts its TLS feature flags fromrustls-tls-native-roots-no-providertorustls-native-certs+rustls-no-provider.Refreshes
Cargo.lockaccordingly, adding new transitive dependencies (notablyrustls-platform-verifierand related Android/JNI and Windows target crates) and updatinghyper-rustls’s dependency set.Reviewed by Cursor Bugbot for commit 756ac71. Bugbot is set up for automated code reviews on this repo. Configure here.