fix(tui): remove blocking loading#394
Conversation
Greptile SummaryThis PR refactors the TUI's loading mechanism from a blocking Confidence Score: 5/5Safe to merge — the refactor is well-structured and the two race conditions flagged in prior threads are correctly resolved by the clears_in_flight flag. No P0 or P1 findings. All IPC completion handlers correctly call stop_loading() and clear in_flight before spawning a post-op refresh. The clears_in_flight: true path for Action::Refresh properly dismisses the overlay and resets in_flight. All branches of synchronous operations (SaveConfig, DeleteDaemon) call stop_loading() in every outcome including error paths. No files require special attention. Important Files Changed
Reviews (5): Last reviewed commit: "fix: misc" | Re-trigger Greptile |
Greptile SummaryThis PR replaces the blocking
Confidence Score: 3/5Not safe to merge as-is — manual refresh leaves a permanent loading overlay. A P1 logic bug causes the 'Refreshing...' loading indicator to never clear after user-triggered refresh, which is a visible and reproducible regression introduced by this PR. The fix is a single line, but the bug affects normal TUI usage. src/tui/mod.rs — TaskResult::Refresh handler at line 269 Important Files Changed
Reviews (2): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile |
fbba1fa to
af8b33f
Compare
## 🤖 New release * `pitchfork-cli`: 2.7.0 -> 2.8.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [2.8.0](v2.7.0...v2.8.0) - 2026-04-28 ### Added - *(boot-start)* support system level register ([#397](#397)) ### Fixed - *(tui)* remove blocking loading ([#394](#394)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
No description provided.