feat(proxy): auto trust if possible#431
Conversation
Greptile SummaryThis PR centralizes all CA certificate trust management into
Confidence Score: 5/5The core trust install/uninstall paths are structurally sound with good rollback handling; the two findings are minor edge cases in error paths that do not affect the happy path. The auto-trust and untrust logic is well-structured with proper rollback on Linux install failure and correct macOS CN extraction. The two issues found are both in error-handling or diagnostic-output paths: one leaks security error text to the terminal during untrust (cosmetic), and one produces a false-positive trust result only if the cert file exists on disk but cannot be read (a very unusual failure mode). Neither affects the primary install/uninstall flow. src/proxy/trust.rs — the delete-certificate loop stdout/stderr and the unwrap_or_default() content-comparison in is_ca_trusted_linux Important Files Changed
Reviews (8): Last reviewed commit: "feat(proxy): try auto trust" | Re-trigger Greptile |
360f4d2 to
a85fcc1
Compare
a85fcc1 to
d7c98b1
Compare
d7c98b1 to
1a1d5dc
Compare
1a1d5dc to
b72de0f
Compare
b72de0f to
32a3337
Compare
32a3337 to
0e2cd6f
Compare
0e2cd6f to
4420ebc
Compare
|
@jdx ready for review! |
No description provided.