-
-
Notifications
You must be signed in to change notification settings - Fork 26
fix: give a user-friendly error when the work fails #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,6 +101,9 @@ impl Start { | |
| } | ||
|
|
||
| if any_failed { | ||
| if last_exit_code != 0 { | ||
| error!("Process exited with code {}", last_exit_code); | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Error Logging Inconsistency Masks FailuresThe |
||
| std::process::exit(last_exit_code); | ||
| } | ||
| Ok(()) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent Logging for Process Exit Codes
The application logs "Process exited with code {}" as an error for successful exit code 0, which is misleading. This occurs unconditionally in
src/cli/run.rs. Insrc/cli/start.rs, individual daemon failures are logged for any exit code, but the final process exit message is only shown for non-zero codes, creating inconsistent failure reporting.Additional Locations (1)
src/cli/run.rs#L58-L59