Skip to content

Use .pk instead of .id when referring to related object.#110

Merged
jedie merged 1 commit intojedie:masterfrom
peterlisak:bug-id
Jan 4, 2019
Merged

Use .pk instead of .id when referring to related object.#110
jedie merged 1 commit intojedie:masterfrom
peterlisak:bug-id

Conversation

@peterlisak
Copy link
Copy Markdown
Contributor

In case of relation to model with primary key which is named differently as id, it is raising the following error when comparing revisions.

'ModelName' object has no attribute 'id'
../site-packages/reversion_compare/compare.py in <setcomp>, line 130

.pk should be used.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 84.283% when pulling f96f972 on peterlisak:bug-id into a304297 on jedie:master.

@jedie
Copy link
Copy Markdown
Owner

jedie commented Jan 4, 2019

That sounds very reasonable.
Thanks for contribution!

@jedie jedie merged commit bb68825 into jedie:master Jan 4, 2019
@jedie
Copy link
Copy Markdown
Owner

jedie commented Jan 4, 2019

@peterlisak it's released as v0.8.6 ;)

@peterlisak
Copy link
Copy Markdown
Contributor Author

@jedie Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants