Skip to content

[iOS] Hide elements in ItemView & PosterButton from voiceover #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samglt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[iOS] Hide elements in ItemView & PosterButton from voiceover #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfe832a
Ignore backdrop images and don't read poster button images
samglt Sep 26, 2025
8329647
hide logos
samglt Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Swiftfin/Components/PosterButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ struct PosterButton<Item: Poster>: View {
.backport
.matchedTransitionSource(id: "item", in: namespace)
.posterShadow()
.accessibilityElement(children: .ignore)
Copy link
Copy Markdown
Member

@LePips LePips Sep 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're gonna have to think more about how to properly set PosterButton, as there are a variety of states we have to consider where this direct ignore may not be correct.

  • when Show poster labels is disabled, the title text is hidden from the label. Instead, an abbreviated title is shown on the poster in the placeholder/failure state.
  • overlay elements like watched, progress, and favorited


label
.eraseToAnyView()
Expand Down
2 changes: 2 additions & 0 deletions Swiftfin/Views/ItemView/ScrollViews/CinematicScrollView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ extension ItemView {
.aspectRatio(usePrimaryImage ? (2 / 3) : 1.77, contentMode: .fill)
.frame(width: proxy.size.width, height: proxy.size.height * 0.6)
.bottomEdgeGradient(bottomColor: bottomColor)
.accessibilityHidden(true)
}
}
}
Expand Down Expand Up @@ -114,6 +115,7 @@ extension ItemView.CinematicScrollView {
}
.aspectRatio(contentMode: .fit)
.frame(height: 100, alignment: .bottom)
.accessibilityHidden(true)
}

DotHStack {
Expand Down
2 changes: 2 additions & 0 deletions Swiftfin/Views/ItemView/ScrollViews/CompactLogoScrollView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ extension ItemView {
.aspectRatio(1.77, contentMode: .fill)
.frame(width: proxy.size.width, height: proxy.size.height * 0.70, alignment: .top)
.bottomEdgeGradient(bottomColor: bottomColor)
.accessibilityHidden(true)
}
}

Expand Down Expand Up @@ -103,6 +104,7 @@ extension ItemView.CompactLogoScrollView {
}
.aspectRatio(contentMode: .fit)
.frame(height: 70, alignment: .bottom)
.accessibilityHidden(true)

DotHStack {
if let firstGenre = viewModel.item.genres?.first {
Expand Down
2 changes: 2 additions & 0 deletions Swiftfin/Views/ItemView/ScrollViews/CompactPortraitScrollView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ extension ItemView {
.aspectRatio(1.77, contentMode: .fill)
.frame(width: proxy.size.width, height: proxy.size.height * 0.78, alignment: .top)
.bottomEdgeGradient(bottomColor: bottomColor)
.accessibilityHidden(true)
}
}
}
Expand Down Expand Up @@ -125,6 +126,7 @@ extension ItemView.CompactPosterScrollView {
.lineLimit(2)
.fontWeight(.semibold)
.foregroundColor(.white)
.accessibilityHidden(true)

DotHStack {
if viewModel.item.type == .person {
Expand Down
2 changes: 2 additions & 0 deletions Swiftfin/Views/ItemView/ScrollViews/iPadOSCinematicScrollView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ extension ItemView {
ImageView(imageSource)
.aspectRatio(1.77, contentMode: .fill)
.bottomEdgeGradient(bottomColor: bottomColor)
.accessibilityHidden(true)
}
}

Expand Down Expand Up @@ -121,6 +122,7 @@ extension ItemView.iPadOSCinematicScrollView {
}
.aspectRatio(contentMode: .fit)
.frame(maxWidth: geometry.size.width * 0.4, maxHeight: 130, alignment: .bottomLeading)
.accessibilityHidden(true)

ItemView.OverviewView(item: viewModel.item)
.overviewLineLimit(3)
Expand Down
⚡