Skip to content

Default Track Settings & Unify VideoPlayerSettingsView#1888

Open
JPKribs wants to merge 32 commits intojellyfin:mainfrom
JPKribs:userCustomizations
Open

Default Track Settings & Unify VideoPlayerSettingsView#1888
JPKribs wants to merge 32 commits intojellyfin:mainfrom
JPKribs:userCustomizations

Conversation

@JPKribs
Copy link
Copy Markdown
Member

@JPKribs JPKribs commented Jan 2, 2026

Summary

Resolves: #1068

Because of how #1581 configured it, we are already pulling the default track selection based on the UserDto.UserConfiguration settings that we get from the server. This PR just adds a new setting to update these values from Swiftfin instead of relying on folks changing this from Jellyfin-Web:

Settings > Playback > Audio Settings
Image

Settings > Subtitles > Subtitles
Image

This PR also fully refactors VideoPlayerSettingsView to be platform agnostic.

This PR also migrates ServerUserAdminViewModel to stateful and cleans up the views that use this. Most of these are a straight change but some of these there was some additional cleanup. The 3 big cleanups were reducing the comments that I originally put in there, combining vars when they were needlessly split up (by me), and finally, removing duplicate deletion logic.

Finally, this PR uses the same ServerUserAdminViewModel to track other server settings as well:

  • isHidePlayedInLatest | Home View
  • isDisplayMissingEpisodes | Item View for Seasons
  • enableNextEpisodeAutoPlay | Player UI + Video Player Settings

These are items we had defaults / stored values for but most clients just pull this from the user configuration of the user session. This migrates these to use the user session > user configuration and updates the callers for these defaults / stored values to instead using the user session > user configuration.

Videos

Swiftfin to Web Sync
Screen.Recording.2026-03-01.at.12.31.53.mov
tvOS
Simulator.Screen.Recording.-.Apple.TV.-.2026-02-27.at.17.18.25.mov
iOS
Simulator.Screen.Recording.-.iPhone.-.2026-02-27.at.17.22.16.mov

@JPKribs JPKribs added enhancement New feature or request iOS Impacts iOS or iPadOS tvOS Impacts tvOS labels Jan 2, 2026
@JPKribs JPKribs changed the title Default Audio / Subtitle Settings Default Track Settings & Unify VideoPlayerSettingsView Feb 28, 2026
@JPKribs
Copy link
Copy Markdown
Member Author

JPKribs commented Mar 2, 2026

This PR is done but there is a lot of localizing. I also touch this same place via other outstanding PRs. When those are closed, I will finish up the localization and finalize this one. Videos are up-to-date!


Edit: Looks like I should do the same with the the days in next up and Enable Rewatching in Next Up to sync those with other clients / web. I will make that it's own PR. The changes here are somewhere more targeted but that change should be simple on top of this.

@JPKribs JPKribs linked an issue Mar 10, 2026 that may be closed by this pull request
@JPKribs JPKribs marked this pull request as ready for review March 15, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request iOS Impacts iOS or iPadOS tvOS Impacts tvOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow subtitle accessibility overrides on Apple TV Add option to set default audio/subtitle tracks

1 participant