Conversation
|
@LePips right now, this is just a lift and fix from iOS. I intend on cleaning this up more for tvOS. Wanted to make a PR to make sure I wasn't conflicting with anything that you were doing. Also, just a confirmation that using iOS as the "base" was fine/expected from your end. Edit: Okay, restarted. I realized what you had there was actually the bones for the new player so I'm using that as the base! |
Apologies for my delayed response. I was waiting for my MBP to arrive so I can more easily screenshot and test the features on real hardware instead of needing to run back and fourth to my office. I compiled the latest changes and the original points for improvement with the player UI have been addressed. The seekbar no longer grows horizontally past everything else and there is no longer a opaque overlay when the player controls are visible. I did however notice a bit of strange behaviour on the top-level player control buttons (the two left most buttons above the seekbar) where when you click on them and trigger their actions, focus immediately moves back to the seekbar, the submenu button (ellipsis icon) does not do this. This may be intentional but it feels awkward to use as no other applications behave this way. Specifically the "aspect fill" and "autoplay" buttons do this. There is also a "jitter" when going to the episodes list while you are on a later episode within a season. It seems that the episode list renders first then selects whatever episode you are on after it has been displayed. Episodes.Jitter.movOther than that all the functionality works well without any issues. |
This isn't intentional but I understand where this comes from. Those buttons are redrawn when selected so I'll need to think about how to preserve focus.
That occurs when first appears to scroll to the active episode. Since it's in it's on container it's been treated as first appearing every time. That's another item I'll need to look at! |
Both of these should be resolved now! If you run into anything further please let me know. Edit, the jitter part is back. If I don't wipe that it caches forever so it gets weird when you go into the next season. |
…o platform view it.
|
Tested everything again and all the issues were resolved. Didn't test for the episodes jitter but did test that it works. From a functionality and UI point of view, this is ready to merge. |
Perfect, thank you for your assistance in testing! It's a great help to have a second set of eyes |
Summary
Resolves: #818
Creates a tvOS version of the iOS Player UI. Attempts to mirror iOS as closely as possible but there are some limitations with UIKit Controllers and focus. iOS we are able to switch between the tabs using gestures and buttons but tvOS we need to account for buttons, swipes, and focus so my implementation of this is a bit different.
Video
Simulator.Screen.Recording.-.Apple.TV.-.2026-03-14.at.03.19.15.mov
Tasks & Goals
Below are the components I wanted to ensure where included/resolves as part of this. At this time, I believe we account for all of the features for this player. Next steps are polish and localization.
FocusGuideLockout When Item ChangesUpdated: 2026-03-11