Conversation
|
This is the second to last "loose" view that isn't combined. The following views are not in folders and not merged with into tvOS that don't have an open/closed PR for their merge:
I suppose also the |
LePips
left a comment
There was a problem hiding this comment.
In testing this, there's a bug where the changing of the user session isn't happening correctly. Signing into user A and then into user B, the accent color and settings values will still reflect user A's settings (and set new values to A's settings, rather than B's). This may have been a longer lasting thing than what I've just seen here, though.
My initial thought, one of the items we're using for tvOS and not iOS is Line 10-27, sorry don't know how to grab lines on mobile Likely, the easiest route would be a global type alias (if that's possible) so tvOS is Ignore the above that's just tvOS but this is applicable to iOS as well. I think we're just not updating the AccentColor on user switch. |
|
The issue isn't with the usage of the There is an issue somewhere that is re-using views. For example, if user A presents the user settings and then switches to user B, when user B presents the user settings the views will not be brand new - they will still be views that hold keys to A's settings. We just may need to stick an |

Summary
Straight forward combination. These are both built on top of the
SelectorViewwhich is already both an iOS and tvOS target. Some cleanup toSelectorViewto use the sameListRowCheckbox()so the image sizing is consistent across the whole Swiftfin. Same reasoning & changes found here: #1823Videos
iOS
Simulator.Screen.Recording.-.iPhone.-.2026-03-09.at.21.55.06.mov
tvOS
Simulator.Screen.Recording.-.Apple.TV.-.2026-03-09.at.21.48.48.mov