Conversation
|
@LePips Let me know what you think. It's a tad overkill. The alternatives to this are just |
LePips
left a comment
There was a problem hiding this comment.
We don't need to introduce this boilerplate just for shared vs platform settings, this should be a fairly slim view itself.
Sounds good. I've reduced this down. I also suppose the goal is to avoid platform specific changes in the future. If needed, build flags can be used for those specific settings as well. I left the if ExperimentalSettingsView.isEnabled {
ChevronButton(L10n.experimental) {
router.route(to: .experimentalSettings)
}
}Alternative is to just comment that out and un-comment it if it's needed. I prefer the |
|
Also, I think this is the last view to combine for now! I was looking at LiveTV, Item, Home, & Search Views but I noticed these seem to be covered in your work in #1752. I have aspirations for a LiveTV GuideView down the road but I think that will still need your changes since you refactor I have some other outstanding PRs but I think what I have open is all I will work on until #1752 is ready! Sorry for side tracking you with all these PRs I appreciate the reviews and feedback! GuideView WIPWIP.mov |
Summary
This might be a tad more controversial. The goal of this one is to get
ExperimentalSettingsViewunified for both iOS and tvOS and wire it up so any future experimental settings are minimally invasive to implement.This leaves a platform specific settings group for iOS or tvOS only settings. Then, there is a shared settings sections for anything on both platforms. I have this wired up in the
SettingsViewto only show ifisEnabledis set to true for this platform.In an ideal world, I'd love
isEnabledto just dynamically trigger based on if theplatformSettingsorsharedSettings.isNotEmptybut I was unable to find a way to do this.The benefit of this PR is that all of the work for enabling a setting in
ExperimentalSettingsViewis done inside the view without needing to interact with theSettingsViewor anything else. This also centralized shared experimental settings so they only need to go into this view instead of iOS and tvOS versions of this view.Flask icon for tvOS shown below:
Simulator.Screen.Recording.-.Apple.TV.-.2026-03-10.at.10.04.09.mov