GitHub Action to Look for Unused Strings#1951
Conversation
- accessibility - childDeletionWarning - children - cinematicBackground - episodeLandscapePoster - missingItems - next - rememberLayoutFooter - rememberSortingFooter - seriesBackdrop - showFavorites - showRecentlyAdded
|
For live usage, please see: https://github.com/jellyfin/Swiftfin/actions/runs/23617837222/job/68789743051 My former commit where I still had our Main unused strings |
LePips
left a comment
LePips
left a comment
There was a problem hiding this comment.
Let's have these smaller checks all in one action, spinning up individual jobs for each one is a bit overkill.
Good call. I've combined Linting and Localization checks into one action called "Validate PR". I'm terrible at naming so let me know if that's a bad name for this. Also, let me know if we want to merge this with CI as well. I think you meant Lint but just checking those are the only 2 to merge. |
LePips
left a comment
LePips
left a comment
There was a problem hiding this comment.
Yep, just like that. Looks great!
2 participants
Summary
The goal of this is to work similarly to our linting but for localization that created but unused in PRs.
This migrates our
PurgeUnusedStrings.swifttoFindUnusedStrings.swift. By default, this script exits as an error when unused strings are found and returns a list of the strings in CLI.To purge strings, you run
FindUnusedStrings.swift --purge.When run on Main, this is what we get:
So this PR also removes these strings to comply with this new Action.
This is what this looks like in CLI and what this looked like to remove these unused strings: