fix: respect mpv_ext_no_ovr setting for OSC control#499
Open
vidonnus wants to merge 1 commit intojellyfin:masterfrom
Open
fix: respect mpv_ext_no_ovr setting for OSC control#499vidonnus wants to merge 1 commit intojellyfin:masterfrom
vidonnus wants to merge 1 commit intojellyfin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #471 - External MPV OSC hidden when launching with mpv-shim
Problem
When using external MPV with
mpv_ext_no_ovrenabled (to prevent mpv-shim from overriding user's MPV config), the OSC (On-Screen Controller) was being hidden on launch. Users had to manually runcycle oscin the MPV console to restore it, and the setting would reset on every new video.The issue occurred because
enable_osc()was unconditionally controlling OSC visibility based on thumbnail settings, even when the user explicitly configured mpv-shim to not override their MPV settings.Solution
Added a check in
enable_osc()to respect thempv_ext_no_ovrsetting. When using external MPV with this setting enabled, mpv-shim now skips OSC control entirely, allowing the user's MPV configuration to take precedence.Changes
PlayerManager.enable_osc()inplayer.pyto return early whenmpv_extandmpv_ext_no_ovrare both enabledTesting
mpv_ext_no_ovrenabled