Open
Conversation
github-project-automation
bot
moved this to In progress
in Jellyfin Vue - Ongoing development
Cloudflare Pages deployment
|
|
Alexk2309
commented
Jun 16, 2025
| <template> | ||
| <GenericItemCard | ||
| :progress="progress" | ||
| :progress="item.Type !== BaseItemKind.Series ? progress : undefined" |
Author
There was a problem hiding this comment.
It doesn't really make sense for a series to have a progress value. It seems like it's actually reflecting the progress of the most recent episode rather than the series as a whole. I understand if this approach isn't ideal, and I'm open to changing it if there's a better way to handle it.
Member
There was a problem hiding this comment.
I agree the progress value should be (episodes_watched / total_episodes) * 100
Member
|
Please use conventional commits from now on (no need to reword/ammend the current ones, because I will squash this PR) but just FYI from now on :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress meter wasn't showing, and this fix should make it work.