Chore/migrate vuetify to unocss more updates#2739
Chore/migrate vuetify to unocss more updates#2739kylemartinperez wants to merge 3 commits intojellyfin:masterfrom
Conversation
github-project-automation
bot
moved this to In progress
in Jellyfin Vue - Ongoing development
|
kylemartinperez
had a problem deploying
to
Preview
GitHub Actions
Failure
ferferga
left a comment
ferferga
left a comment
There was a problem hiding this comment.
Make sure you have the UnoCSS extension that highlights which classes are recognized by UnoCSS and which classes aren't
If you start the app with npm start at frontend directory, the console will show you a link to the UnoCSS Inspector, which is really useful to debug this kind of thing.
| <template> | ||
| <VContainer | ||
| class="fill-height" | ||
| class="uno-h-height" |
There was a problem hiding this comment.
This is not equivalent
You can check the Vuetify CSS as extracted from this project here
.v-container.fill-height {
flex-wrap: wrap;
align-items: center;
display: flex;
}
| md="6" | ||
| lg="5"> | ||
| <h1 class="text-h4 mb-6 text-center"> | ||
| <h1 class="text-h4 uno-mb-6 uno-text-center"> |
There was a problem hiding this comment.
I'm fine with doing this in small batches, so it's easier to review, but if a file is touched, I'd rather have all classes updated along the way. Here text-h4 is left untouched.
| <JHover v-slot="{ isHovering }"> | ||
| <div | ||
| class="ma-2 d-flex flex-column pointer" | ||
| class="uno-m-2 uno-flex uno-flex-column pointer" |
There was a problem hiding this comment.
uno-flex-column is not a valid unocss class
| <JTooltip position="bottom"> | ||
| <VBtn | ||
| class="align-self-center ma-1" | ||
| class="uno-align-self-center uno-m-1" |
There was a problem hiding this comment.
uno-align-self-center doesn't exist
github-project-automation
bot
moved this from In progress
to In review
in Jellyfin Vue - Ongoing development
2 participants
doing some more work on issue #2538
files and their paths that have been updated:
frontend/src/layouts/server.vue frontend/src/components/Layout/AppBar/AppBarButtonLayout.vue frontend/src/components/Layout/Images/Blurhash/BlurhashImageIcon.vue frontend/src/components/Buttons/ScrollToTopButton.vue frontend/src/components/Users/UserCard.vue frontend/src/pages/server/add.vue frontend/src/components/Layout/SettingsPage.vue frontend/src/components/Item/PeopleList.vue frontend/src/components/Item/CollectionTabs.vue