contain loose ref names within the ref store in refpath#2212
Closed
netliomax25-code wants to merge 1 commit into
Closed
contain loose ref names within the ref store in refpath#2212netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
Owner
|
Addressed in #2234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loose ref names reach DiskRefsContainer.refpath from lookups that skip the validation the write paths get (_check_refname): read_loose_ref, follow's resolved symref target, and git-upload-archive's client-supplied
argumentin server.py. os.path.join honors..and absolute names, so resolving a name like../../secretreads a file outside the ref store and hands back its first line as the ref value. Enforce containment in refpath so every read and write site is covered at the one chokepoint.