index: match git on invalid checkout paths#2235
Merged
Merged
Conversation
Contributor
|
This seems to fix the issue, thanks. However, the dulwich CLI crashes with scary backtrace with a bad repo. |
2ec3c9e to
abd0891
Compare
Two related fixes for issue #2205: The NTFS path-element validator rejected any element containing ':' or '\', so files with a colon in their name (e.g. with:colon.txt) were silently dropped on clone. Reject only the '.git'/'git~1' alternate-data- stream spellings instead, like git: a bare colon is accepted, and a backslash is only rejected as a separator on Windows while still terminating the .git scan on every platform. When a tree entry's path is genuinely invalid, abort the checkout rather than silently skipping the entry. Fixes #2205
abd0891 to
7544dcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NTFS path-element validator rejected any element containing ':' or '', so files with a colon in their name (e.g. with:colon.txt) were silently dropped on clone. Reject only the '.git'/'git~1' alternate-data- stream spellings instead, like git: a bare colon is accepted, and a backslash is only rejected as a separator on Windows while still terminating the .git scan on every platform.
When a tree entry's path is genuinely invalid, abort the checkout rather than silently skipping the entry.
Fixes #2205