#186 - LENIENT mode allows GPX tags without creator attributes#187
Merged
jenetics merged 3 commits intojenetics:releases/r3.2.1from Jan 9, 2025
r-follador:master
Merged
#186 - LENIENT mode allows GPX tags without creator attributes#187jenetics merged 3 commits intojenetics:releases/r3.2.1from r-follador:master
jenetics merged 3 commits intojenetics:releases/r3.2.1from
r-follador:master
Conversation
jenetics
requested changes
Jan 9, 2025
Owner
jenetics
left a comment
jenetics
left a comment
There was a problem hiding this comment.
@r-follador, thank you for the improvement and PR.
Just one small comment.
jenetics
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186 ; remove requireNonNull for creator attribute and add test case to differentiate LENIENT and STRICT mode.