plugin modernization to reduce hpi size#355
Conversation
- use 2.452.4 as minimum Jenkins version - replace dependency to jackson, gson and commons-lang3 with the corresponding api plugins - remove dependency to groovy. It is not needed and only blows up the hpi. - remove dependencies to annotation-indexer and structs as they are not required
|
Hi @mawinter69 The minimum Jenkins version shouldn't be changed at the moment, so that installations running on older versions of Jenkins can still use the updated versions of the plugin. You can look at the distribution of installations in this matrix: https://old.stats.jenkins.io/pluginversions/bitbucket-push-and-pull-request.html Instead of the @SuppressFBWarnings(value="PA_PUBLIC_PRIMITIVE_ATTRIBUTE", justification="Preserve API compatibility") annotation, could you use the method shown in the official documentation? https://spotbugs.readthedocs.io/en/latest/maven.html#add-spotbugs-maven-plugin-to-your-pom-xml. For example:
|
1262df9 to
8ea69dc
Compare
8ea69dc to
d6aa3bb
Compare
|
The gson-api plugin is only available from 2.401.3 so I used that as the baseline. Given that most users that are on a Jenkins older than 2.401.3 are using this plugin also with an older release I think that the impact is not really big to increase the minimum required Jenkins version. |
7fd310c to
f820cd0
Compare
|
@mawinter69 Merged and released, thanks! |
The size of the hpi is reduced from over 9MiB to 342KiB
Testing done
Don't have access to bitbucket but the tests are running fine
Submitter checklist