Skip to content

Migrate tests to JUnit5#369

Merged
cdelmonte-zg merged 1 commit intojenkinsci:devfrom
strangelookingnerd:migrate_to_junit5
Sep 2, 2025
Merged

Migrate tests to JUnit5#369
cdelmonte-zg merged 1 commit intojenkinsci:devfrom
strangelookingnerd:migrate_to_junit5

Conversation

@strangelookingnerd
Copy link
Copy Markdown
Contributor

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations and imports
  • Migrate assertions
  • Remove public visibility for test classes and methods
  • Minor clean up

I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@cdelmonte-zg cdelmonte-zg changed the base branch from master to dev June 29, 2025 09:24
@cdelmonte-zg
Copy link
Copy Markdown
Contributor

@strangelookingnerd would you please solve the conflicts? thank you :)

* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor code cleanup
@cdelmonte-zg cdelmonte-zg merged commit 3adab2d into jenkinsci:dev Sep 2, 2025
14 of 16 checks passed
cdelmonte-zg added a commit that referenced this pull request Nov 24, 2025
- Add CHANGELOG entry for version 3.3.0
  - Document Draft PR Support feature (#367)
  - Document JUnit5 migration (#369)
  - Document build fix (#371)

- Update README with new environment variable
  - Add BITBUCKET_PULL_REQUEST_IS_DRAFT to env vars table
  - Add practical examples for skipping draft PR builds
  - Update pipeline example to show new variable

- Add .claude to .gitignore

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants