Skip to content

chore(Windows): define tags in docker compose file instead of code #550

Merged
lemeurherve merged 5 commits intojenkinsci:masterfrom
lemeurherve:feat-tags-in-docker-compose
Feb 10, 2024
Merged

chore(Windows): define tags in docker compose file instead of code #550
lemeurherve merged 5 commits intojenkinsci:masterfrom
lemeurherve:feat-tags-in-docker-compose

Conversation

@lemeurherve
Copy link
Copy Markdown
Member

@lemeurherve lemeurherve commented Oct 27, 2023

This PR allows to define Windows images tags in docker compose file instead of relying on code in build.ps1 script, and to use the docker compose file for pushing the images and their tags.

Using docker compose like what has been done in jenkinsci/docker#1770 simplifies code logic and might improve publication time.

Changes without the cherry-picks of #547, #548 & #549 to review: c706390

Rebased from the primary branch to take #570 in account.

Testing done

  • Compared pwsh build.ps1 publish -DryRun outputs before and after
  • CI tests
### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lemeurherve lemeurherve changed the title feat(Windows): use docker-compose file for tags feat(Windows): use docker compose to publish images Nov 8, 2023
@lemeurherve lemeurherve force-pushed the feat-tags-in-docker-compose branch from a4bb4f4 to 414c6fc Compare January 13, 2024 16:49
@lemeurherve lemeurherve changed the title feat(Windows): use docker compose to publish images feat(Windows): define tags in docker compose file instead of code Jan 13, 2024
@lemeurherve lemeurherve changed the title feat(Windows): define tags in docker compose file instead of code chore(Windows): define tags in docker compose file instead of code Jan 14, 2024
@lemeurherve lemeurherve force-pushed the feat-tags-in-docker-compose branch from 1e88d84 to 2cda621 Compare January 14, 2024 18:35
@lemeurherve lemeurherve marked this pull request as ready for review January 14, 2024 19:34
@lemeurherve lemeurherve requested a review from a team as a code owner January 14, 2024 19:34
@lemeurherve lemeurherve force-pushed the feat-tags-in-docker-compose branch from b92b0ff to 5c73a24 Compare January 14, 2024 19:56
@lemeurherve lemeurherve force-pushed the feat-tags-in-docker-compose branch from 3578ada to 6d2e7cc Compare January 14, 2024 22:23
@lemeurherve
Copy link
Copy Markdown
Member Author

Gentle ping @jenkinsci/team-docker-packaging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants