This repository was archived by the owner on Jan 21, 2024. It is now read-only.
Use JENKINS_SECRET and JENKINS_NAME env vars if present#24
Merged
oleg-nenashev merged 2 commits intomasterfrom Mar 16, 2017
Merged
Use JENKINS_SECRET and JENKINS_NAME env vars if present#24oleg-nenashev merged 2 commits intomasterfrom
oleg-nenashev merged 2 commits intomasterfrom
Conversation
Member
|
@reviewbybees |
jglick
suggested changes
Feb 21, 2017
| # * JENKINS_TUNNEL : HOST:PORT for a tunnel to route TCP traffic to jenkins host, when jenkins can't be directly accessed over network | ||
| # * JENKINS_URL : alternate jenkins URL | ||
| # * JENKINS_SECRET : agent secret, if not set as an argument | ||
| # * JENKINS_NAME : agent name, if not set as an argument |
Member
There was a problem hiding this comment.
JENKINS_SLAVE_NAME would be clearer. Or better yet, JENKINS_AGENT_NAME with SLAVE_NAME replaced by AGENT_NAME above.
Contributor
Author
There was a problem hiding this comment.
IIRC name and secret are the var names used in remoting
Member
There was a problem hiding this comment.
Yes, +1 for JENKINS_AGENT_NAME
oleg-nenashev
approved these changes
Feb 22, 2017
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Member
|
@reviewbybees done |
jglick
approved these changes
Feb 27, 2017
lemeurherve
pushed a commit
to lemeurherve/jenkinsci-docker-inbound-agent
that referenced
this pull request
Nov 19, 2023
Update README.md
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…kinsci/envvars Use JENKINS_SECRET and JENKINS_NAME env vars if present
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…kinsci/envvars Use JENKINS_SECRET and JENKINS_NAME env vars if present
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…kinsci/envvars Use JENKINS_SECRET and JENKINS_NAME env vars if present
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…kinsci/envvars Use JENKINS_SECRET and JENKINS_NAME env vars if present
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Jan 12, 2024
…nvvars Use JENKINS_SECRET and JENKINS_NAME env vars if present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix jenkinsci/docker-agents#744