fix: Correct NodesMirror package and add label quantity regression tests#1028
Open
mPokornyETM wants to merge 3 commits intomasterfrom
Open
fix: Correct NodesMirror package and add label quantity regression tests#1028mPokornyETM wants to merge 3 commits intomasterfrom
mPokornyETM wants to merge 3 commits intomasterfrom
Conversation
…ture NodesMirror.java resides in the nodes/ subdirectory but declared package org.jenkins.plugins.lockableresources instead of org.jenkins.plugins.lockableresources.nodes. Fix the package declaration and update fully-qualified references in ConcurrentModificationExceptionTest and NodesMirrorTest.
Add LockStepLabelQuantityOneTest with three test scenarios for JENKINS-67083: 3 resources with the same label and 3 concurrent builds each requesting quantity 1. All three tests pass, confirming the issue is no longer reproducible.
Contributor
|
⏸️ Auto-merge countdown PAUSED: CI checks are not passing. The countdown will resume when all checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes:
Fix NodesMirror package declaration —
NodesMirror.javaresides in thenodes/subdirectory but declaredpackage org.jenkins.plugins.lockableresourcesinstead oforg.jenkins.plugins.lockableresources.nodes. This corrects the package declaration and updates fully-qualified references inConcurrentModificationExceptionTestandNodesMirrorTest.Add regression tests for [JENKINS-67083] Lockable resources plugin only uses 2 resources out of 3 #939 (JENKINS-67083) — three test scenarios covering the reported issue where only 2 out of 3 label-matched resources were allocated when 3 concurrent builds each requested
lock(label: '...', quantity: 1). All tests pass, confirming the issue is no longer reproducible.Test scenarios
threeBuildsEachLockOneOfThreeResourcesimx8, 3 concurrent builds eachlock(label: 'imx8', quantity: 1)— all must acquire concurrentlyfourthBuildWaitsThenProceedsWhenResourceFreedthreeBuildsGetDistinctResourcesBoard_*resource viavariable: 'LOCK_NAME'Closes #939