Add updateLock pipeline step for resource management#980
Merged
mPokornyETM merged 4 commits intomasterfrom Apr 3, 2026
Merged
Conversation
Contributor
Author
|
I can confirm that ma locale developer tests (on windows with Java 25) are OK |
Contributor
|
|
46f527d to
ff0dd32
Compare
Contributor
|
⏸️ Auto-merge countdown PAUSED: CI checks are not passing. The countdown will resume when all checks are green. |
This step allows pipelines to dynamically manage lockable resources: - Create new resources (createResource: true) - Delete existing resources (deleteResource: true) - Modify labels (setLabels, addLabels, removeLabels) - Set notes (setNote) Based on the original design from PR #305 by @gaspardpetit. Fixes #305
Addresses security warnings from github-advanced-security[bot]: - Add @RequirePOST annotation to doCheckResource, doCheckAddLabels, doCheckRemoveLabels, and doCheckDeleteResource - Add @AncestorInPath Item parameter and permission checks to prevent unauthorized form validation calls
ff0dd32 to
8f6c10e
Compare
Contributor
|
✅ Auto-approved: No review received within 3 days. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new \updateLock\ pipeline step that allows pipelines to dynamically manage lockable resources without using the Jenkins UI.
Features
Example Usage
\\groovy
pipeline {
agent any
stages {
stage('Setup') {
steps {
// Create a resource if it doesn't exist
updateLock(resource: 'my-resource', createResource: true, setLabels: 'env-test')
}
}
stage('Use') {
steps {
lock('my-resource') {
echo 'Using the resource'
}
}
}
stage('Cleanup') {
steps {
// Optionally delete the resource
updateLock(resource: 'my-resource', deleteResource: true)
}
}
}
}
\\
Validation
Prior Art
This is a fresh implementation based on the original design from PR #305 by @gaspardpetit, which became stale after 4+ years. Closes #305.
Testing
Automated Tests
Manual Testing Steps
\\�ash
mvn hpi:run
\
Then in Jenkins:
Performance Impact