feat: Add option to disable automatic ephemeral resource creation#986
Merged
github-actions[bot] merged 2 commits intomasterfrom Apr 10, 2026
Merged
Conversation
Contributor
|
⏸️ Auto-merge countdown PAUSED: CI checks are not passing. The countdown will resume when all checks are green. |
38395f5 to
9b7c8fb
Compare
Contributor
|
⏳ Auto-merge countdown: This PR will be auto-approved in 2 day(s) if no review is submitted. |
4323e71 to
6adf44a
Compare
Contributor
|
|
6adf44a to
d0588ec
Compare
Contributor
|
✅ Auto-approved: No review received within 3 days. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new global configuration option
allowEphemeralResourcesthat controls whether resources are automatically created when a job tries to lock a non-existent resource.Fixes #651
Changes
allowEphemeralResourcesboolean field toLockableResourcesManager(default:truefor backward compatibility)createResource()to check the setting before creating ephemeral resourcesBehavior
allowEphemeralResources: true(default)allowEphemeralResources: falseNote:
createResourceWithLabel()is not affected by this setting (allows explicit admin creation even when ephemeral resources are disabled).Testing
EphemeralResourcesOptionTest- 7 tests covering default behavior, disabled behavior, configuration toggles, and label-based lockingConfigurationAsCodeTest- JCasC integration verifiedSupersedes
This is a clean implementation that supersedes #751 (which had merge conflicts and stale code).