Skip to content

feat: Add option to disable automatic ephemeral resource creation#986

Merged
github-actions[bot] merged 2 commits intomasterfrom
feature/disable-ephemeral-resources
Apr 10, 2026
Merged

feat: Add option to disable automatic ephemeral resource creation#986
github-actions[bot] merged 2 commits intomasterfrom
feature/disable-ephemeral-resources

Conversation

@mPokornyETM
Copy link
Copy Markdown
Contributor

@mPokornyETM mPokornyETM commented Apr 3, 2026

Summary

Adds a new global configuration option allowEphemeralResources that controls whether resources are automatically created when a job tries to lock a non-existent resource.

Fixes #651

Changes

  • Added allowEphemeralResources boolean field to LockableResourcesManager (default: true for backward compatibility)
  • Modified createResource() to check the setting before creating ephemeral resources
  • Added UI configuration checkbox in the global settings
  • Added help documentation for the new option
  • Added JCasC (Configuration as Code) support
  • Added comprehensive tests (7 new tests)

Behavior

Setting Behavior
allowEphemeralResources: true (default) Current behavior - resources are auto-created when locked
allowEphemeralResources: false Jobs will block waiting for the resource to be manually created

Note: createResourceWithLabel() is not affected by this setting (allows explicit admin creation even when ephemeral resources are disabled).

Testing

  • EphemeralResourcesOptionTest - 7 tests covering default behavior, disabled behavior, configuration toggles, and label-based locking
  • ConfigurationAsCodeTest - JCasC integration verified

Supersedes

This is a clean implementation that supersedes #751 (which had merge conflicts and stale code).

@mPokornyETM mPokornyETM requested a review from a team as a code owner April 3, 2026 21:40
@github-actions github-actions Bot added enhancement java Pull requests that update Java code localization tests frontend and removed enhancement labels Apr 3, 2026
@mPokornyETM mPokornyETM changed the title feat: Add option to disable automatic ephemeral resource creation (fi… feat: Add option to disable automatic ephemeral resource creation Apr 3, 2026
@mPokornyETM mPokornyETM added the merge-in-3-days-without-review Auto-approve countdown label Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2026

⏸️ Auto-merge countdown PAUSED: CI checks are not passing. The countdown will resume when all checks are green.

@github-actions github-actions Bot force-pushed the feature/disable-ephemeral-resources branch from 38395f5 to 9b7c8fb Compare April 4, 2026 21:56
@github-actions github-actions Bot added merge-in-2-days-without-review Auto-approve countdown and removed merge-in-3-days-without-review Auto-approve countdown labels Apr 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

Auto-merge countdown: This PR will be auto-approved in 2 day(s) if no review is submitted.

@github-actions github-actions Bot force-pushed the feature/disable-ephemeral-resources branch from 4323e71 to 6adf44a Compare April 6, 2026 20:14
@github-actions github-actions Bot added merge-in-1-day-without-review Auto-approve countdown and removed merge-in-2-days-without-review Auto-approve countdown labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

⚠️ Auto-merge countdown: This PR will be auto-approved in 1 day(s) if no review is submitted.

@github-actions github-actions Bot force-pushed the feature/disable-ephemeral-resources branch from 6adf44a to d0588ec Compare April 7, 2026 13:58
@github-actions github-actions Bot removed the merge-in-1-day-without-review Auto-approve countdown label Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Auto-approved: No review received within 3 days. Merging now.

@github-actions github-actions Bot added the merged-without-review Auto-approve countdown label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: no review received within 3 days of opening.

@github-actions github-actions Bot enabled auto-merge (squash) April 8, 2026 08:20
@github-actions github-actions Bot merged commit e94e170 into master Apr 10, 2026
17 checks passed
@github-actions github-actions Bot deleted the feature/disable-ephemeral-resources branch April 10, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement frontend java Pull requests that update Java code localization merged-without-review Auto-approve countdown tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add feature to prevent creation of Ephemeral resources

1 participant