Skip to content

[JENKINS-48510] Add parameter for milestone classification#17

Open
stchar wants to merge 1 commit intojenkinsci:masterfrom
stchar:feature/milestone-classification
Open

[JENKINS-48510] Add parameter for milestone classification#17
stchar wants to merge 1 commit intojenkinsci:masterfrom
stchar:feature/milestone-classification

Conversation

@stchar
Copy link
Copy Markdown

@stchar stchar commented Feb 4, 2019

Added optional parameter group, to cancel builds which are in one milestone's group.
builds with different groups don't interfere with each other.

@stchar stchar force-pushed the feature/milestone-classification branch 2 times, most recently from dc06d06 to 64e674e Compare February 8, 2019 10:48
@nickbroon
Copy link
Copy Markdown

This would definitely be a useful feature.
I have a pipeline job that's triggered by an external tool, and depending on a value of a parameter set by the trigger a milestone group would be useful manage builds.

@agill17
Copy link
Copy Markdown

agill17 commented May 17, 2019

This will be very handy and will reduce redundancy of jobs I have to create and manage.

@stchar and @nickbroon whats blocking this PR from getting merged?

@stchar stchar force-pushed the feature/milestone-classification branch from 64e674e to e9fd09b Compare May 16, 2020 09:57
@stchar
Copy link
Copy Markdown
Author

stchar commented May 16, 2020

rebased

@swrap
Copy link
Copy Markdown

swrap commented Jul 16, 2021

Any update on getting this merged?

@amuniz - are you a maintainer?

@amuniz
Copy link
Copy Markdown
Member

amuniz commented Jan 13, 2022

I don't think I'll have the time needed to properly review and test this PR any time soon. Sorry.
Maybe @car-roll or @rsandell?

@@ -118,20 +146,20 @@ public String getDisplayName() {
@Override
public void load() {
super.load();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would appear to break upgrades where data was persisted as milestonesByOrdinalByJob but will be missing on restart as the map will be null.

Copy link
Copy Markdown
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like as the new version does not load previously persisted data and manage it correctly it will break upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants