[JENKINS-48510] Add parameter for milestone classification#17
[JENKINS-48510] Add parameter for milestone classification#17stchar wants to merge 1 commit intojenkinsci:masterfrom
Conversation
dc06d06 to
64e674e
Compare
|
This would definitely be a useful feature. |
|
This will be very handy and will reduce redundancy of jobs I have to create and manage. @stchar and @nickbroon whats blocking this PR from getting merged? |
64e674e to
e9fd09b
Compare
|
rebased |
|
Any update on getting this merged? @amuniz - are you a maintainer? |
| @@ -118,20 +146,20 @@ public String getDisplayName() { | |||
| @Override | |||
| public void load() { | |||
| super.load(); | |||
There was a problem hiding this comment.
this would appear to break upgrades where data was persisted as milestonesByOrdinalByJob but will be missing on restart as the map will be null.
jtnord
left a comment
There was a problem hiding this comment.
looks like as the new version does not load previously persisted data and manage it correctly it will break upgrades.
Added optional parameter
group, to cancel builds which are in one milestone's group.builds with different groups don't interfere with each other.