Add option for --first-parent in changelog#23
Conversation
This adds an option to select whether or not --first-parent is passed to "git log" when determining the changelog. The default value is to include it.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Configured jobs before this change will default to not have --first-parent. Because when the job is read from disk the first-parent field is missing and so will be set to the boolean default which is false. |
|
@rsandell I can reverse the logic so if it is checked |
|
Reverse logic is usually hard to grok. But in this case it might be OK. You could also make the field into a Boolean reference and add a readResolve that would check if it is null and in that case set it to true, so old configs get converted, or check for null in the get and return true. |
Renaming this option and reversing the logic effectively allows backwards compatibility with the existing plugin behavior.
|
I've renamed the parameter and reversed the logic. Hopefully it isn't too confusing. |
Add option for --first-parent in changelog
This adds an option to select whether or not --first-parent is
passed to "git log" when determining the changelog. The default
value is to include it.