Merged
Conversation
Properly return SCMRevisionState.NONE and handle the cases when we get this back from the API.
rsandell
reviewed
Oct 31, 2016
| public static List<ChangeLogEntry> generateChangeLog( | ||
| final RevisionState currentState, | ||
| final RevisionState previousState, final Launcher launcher, | ||
| private static List<ChangeLogEntry> generateChangeLog( |
Member
There was a problem hiding this comment.
Normally, changing the compatibility like this is a bit frowned upon since it might not be safe to upgrade if an old plugin is relying on the public method. We normally then annotate with @Restricted(NoExternalUse.class) instead, so that when a plugin bumps the dependency it will get a compilation error instead.
But in this case I doubt that any external code has been using it so it should be safe to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analysis in JENKINS-36703 was right, instead of
nullSCMRevisionState.NONEshould have been returned and properly handled. This is done in b760e06. The other commit is unrelated, so in case upstream does not support these stylistic changes, it might just cherry-pick the first one.