feat: Add weekendColor prop to highlight weekend columns#2
Open
jeonghanyun wants to merge 1 commit intomainfrom
Open
feat: Add weekendColor prop to highlight weekend columns#2jeonghanyun wants to merge 1 commit intomainfrom
jeonghanyun wants to merge 1 commit intomainfrom
Conversation
- Add weekendColor prop to StylingOption interface - Add weekendColor support in GridBodyProps and GridBody component - Implement weekend detection logic using getDay() (0=Sunday, 6=Saturday) - Add weekend column highlighting with configurable color - Update Gantt component to accept and pass weekendColor prop - Add weekendColor usage examples in example app (#97979714) - Update README.md with weekendColor documentation - Change todayColor default from rgba(252, 248, 227, 0.5) to rgba(252, 248, 227, 1) Based on PR MaTeMaTuK#122 from MaTeMaTuK/gantt-task-react by AquilesOliveiraDev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎨 Weekend Color Support Feature
이 PR은 MaTeMaTuK/gantt-task-react PR #122의 "Add new prop weekendColor to grid" 기능을 한국어 버전에 적용한 것입니다.
✨ 주요 기능
🗓️ Weekend Highlighting
transparent) 설정으로 주말 하이라이트 비활성화 가능🔧 사용 예제
🎯 기능 설명
"transparent"(주말 하이라이트 없음)"#97979714"(반투명 회색)getDay()값이 0(일요일) 또는 6(토요일)일 때 색상 적용📁 변경된 파일들
Core Files
src/types/public-types.ts: weekendColor prop을 StylingOption에 추가src/components/grid/grid-body.tsx: 주말 감지 및 색상 적용 로직src/components/gantt/gantt.tsx: weekendColor prop 전달Example Files
example/src/App.tsx: weekendColor 사용 예제 추가Documentation
README.md: weekendColor 문서 추가🔄 기타 변경사항
todayColor기본값을rgba(252, 248, 227, 0.5)에서rgba(252, 248, 227, 1)로 변경 (원본 PR과 동일)✅ 테스트
🙏 Credit
Original PR by @AquilesOliveiraDev - PR #122
이 기능으로 주말에 특별한 규칙이 적용되는 프로젝트에서 시각적으로 주말을 구분할 수 있게 되었습니다! 🎉