Support simple alphabet error correct level#67
Open
fetus-hina wants to merge 2 commits intojeromeetienne:masterfrom
Open
Support simple alphabet error correct level#67fetus-hina wants to merge 2 commits intojeromeetienne:masterfrom
fetus-hina wants to merge 2 commits intojeromeetienne:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current minified code, the QRErrorCorrectLevel variable is not exported to global namespace.
Users must use option like
{correctLevel:3, ...}to change error correct level to "Q".So, it's not user-friendly.
This PR add support simple alphabet error correction level.
Users will be able to written as
{correctLevel:"Q", ...}.This PR is fixed #62 and related to #23.
As other approaches, export the QRErrorCorrectLevel variable to global namespace.
But might it not preferable, because it pollute the global namespace.