fix: use relative asset paths so --baseuri works with Vite build#1110
Merged
Conversation
Vite defaults `base` to `/`, which makes the built HTML reference assets with absolute paths like `/assets/index-xxx.js`. When `--baseuri` is set (e.g. `/flood`), the server registers routes under that prefix, but the browser still requests assets from the root — resulting in 404s. Setting `base: './'` makes all asset references relative, so `./assets/xxx` correctly resolves under any base URI. Fixes jesec#1109
qBittorrent 5.2.0 was released on 2026-05-03 and breaks several integration tests (add-urls, trackers, contents). Pin to the last known-good release until the test suite is updated for 5.2.0.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite defaults
baseto/, which makes the built HTML reference assets with absolute paths like/assets/index-xxx.js. When--baseuriis set (e.g./flood), the server registers routes under that prefix, but the browser still requests assets from the root — resulting in 404s.Setting
base: './'in the Vite config makes all asset references relative, so./assets/xxxcorrectly resolves under any base URI.Fixes #1109