Skip to content

Added units of measure to throttle speeds#899

Merged
trim21 merged 1 commit into
jesec:masterfrom
lnxd:master
Jul 7, 2025
Merged

Added units of measure to throttle speeds#899
trim21 merged 1 commit into
jesec:masterfrom
lnxd:master

Conversation

@lnxd

@lnxd lnxd commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Description

I had this issue in the past which led me to find (and answer) the linked discussion page.

But I had the issue again today, so decided to implement a fix.

I considered adding translations for:

settings.bandwidth.transferrate.global.throttle.download
settings.bandwidth.transferrate.global.throttle.upload

For every language as some have their own preferred units of measure, but B/s seems fairly universal.

There was precedent for this change in client/src/javascript/components/modals/settings-modal/ResourcesTab.tsx

Related Issue

#546

Screenshots

Before:

Screenshot 2025-07-07 at 2 43 02 PM

After:

image

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@trim21 trim21 enabled auto-merge (squash) July 7, 2025 09:09
@trim21 trim21 merged commit f22fd4c into jesec:master Jul 7, 2025
18 checks passed
@trim21

trim21 commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants