Merged
Conversation
Also, fix a big in Decimal128's `toPrecision` failing on integers.
Also, call our class "Decimal" rather than "Decimal128".
There are a couple of checks in one of the abstract operations that seems pretty difficult to cover. It may actually be impossible, but I haven't proved that yet. In the meantime, we'll downgrade the requirement.
Having learned about c8 directives to ignore statements/conditionals, I prefer to use that to mark lines that are difficult (or impossible) to test rather than univerally downgrade our code coverage requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose here is to support the currently proposed
Decimal.Amountprimordial. See here for the details in the proposal-decimal repo.