Start Jest with the --no-color CLI argument

[seanpoulter]

This PR will prevent the ANSI escape codes from appearing in the test messages. This is dependent on a change to jest-editor-support that adds the --no-color option (jestjs/jest#5909).

[coveralls]

Pull Request Test Coverage Report for Build 427

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 84.007%

---

Totals
Change from base Build 426:	0.0%
Covered Lines:	690
Relevant Lines:	806

---

💛 - Coveralls

[orta]

I’ve merged the other, but this now relies on a new jest release

[seanpoulter]

We're still waiting for a Jest deployment. It's making me wish we could go bump jest-editor-support on it's own.

[orta]

There's nearly always a jest release: https://www.npmjs.com/package/jest (see versions)

[stephtr]

Switching to a beta release of jest-editor-support (for example 23.0.0-charlie.2 as done within #297) should work (since it doesn't contain any other beside our own changes).

[seanpoulter]

I wonder if we can fix this issue now without the option. 🤔

[stephtr]

You mean without the --no-color option?

[seanpoulter]

I wonder if we can fix this issue now without the option. 🤔

On second thought it's not worth any thought.

Switching to a beta release of jest-editor-support ... should work

Do we need to worry about breaking anything else? Things aren't very stable right now ... 🔥

[stephtr]

I can't think of any new instability since there had been only a handful of changes (mostly made by us) which I think only introduced new features. I already tested it with my PR and didn't notice any issues.
But since Jest 23 has been released on Thursday we probably need some testing anyhow.

[connectdotz]

@seanpoulter once we merge #341, we should be in sync with the latest jest-editor-support that this PR depends on.

The change is small and simple, I see no problem in merging in, just need to resolve the merge conflict as there are many PRs went ahead of this one...

[seanpoulter]

Was there something about Jest 23 that solved this problem for us? I don't remember ...

[connectdotz]

the new option noColor depends on the the changes in jest-editor-support jest/5909 you submitted a while back. Not sure which exact jest version includes that change, but with jest 23.3 (updated in #341) I know for sure it is in there.

During #341, I briefly tested the noColor option and it seems to work, however I have only tested with jest 23.x. I think as long as it won't break other jest versions, we should be fine.

[seanpoulter]

OK, thanks for refreshing my memory. I'll rebase that when I get a few moments.

[seanpoulter]

I've rebased the PR which should be good to go @connectdotz.

[connectdotz]

thanks @seanpoulter