Skip to content

chore: use typescript-eslint to parse all files#10722

Merged
SimenB merged 1 commit intojestjs:masterfrom
SimenB:ts-eslint
Oct 26, 2020
Merged

chore: use typescript-eslint to parse all files#10722
SimenB merged 1 commit intojestjs:masterfrom
SimenB:ts-eslint

Conversation

@SimenB
Copy link
Copy Markdown
Member

@SimenB SimenB commented Oct 26, 2020

Summary

Why not 🤷

Test plan

Green CI

Copy link
Copy Markdown
Contributor

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread .eslintrc.js
},
},
],
parser: 'babel-eslint',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get rid of babel-eslint then?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not without peer dep warnings (facebook/fbjs#405)

@SimenB SimenB changed the title chore: use typescript-eslint to parse all files chore: use typescript-eslint to parse all files Oct 26, 2020
@SimenB SimenB merged commit 08c8fca into jestjs:master Oct 26, 2020
@SimenB SimenB deleted the ts-eslint branch October 26, 2020 21:35
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants