feat: sequencer saving may be async#10980
Merged
SimenB merged 1 commit intojestjs:masterfrom Dec 26, 2020
Merged
Conversation
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow a
TestSequencerimplementation to performasyncoperations during itsallFailedTestsandcacheResultsphases.It's already allowed for
sort, but not for the other methods, which I believe are part of the public/extensible API.My Sequencer wants to go to a database.
Test plan
There's already a test for
sort, and I've added a similar test forallFailedTests.It's hard to directly test
cacheResultsis awaited, as it's void. We could attempt to catch it with sleeps and testing the implementation ordering; e.g. checking if it has completed before theglobalHookhas run? It doesn't seem to have any value.awaiting it is necessary, as otherwise longercacheResultsimplementations eventually trigger theJest did not exit one second after the test run has completed.failure.